feat: add env var to silence pr comments #4415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anryko
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
jamengual
added
needs discussion
|
Closing in favor of #4543. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silence PR Comments
PoC implementation for the simplest case of silencing PR comments via setting
ATLANTIS_SILENCE_PR_COMMENTS=true(defaultfalse) environment variable.ℹ️ This is not a complete feature. Just testing if this approach is acceptable before taking on the rest of the functionality.
why
When a user has many Atlantis servers planning Terraform change it causes a lot of comment noise in the GitHub PR thread. They might want to rely solely on the GitHub status checks in those cases.
tests
references