Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(renovate): set minimumReleaseAge for 5 days #4434

Merged
merged 7 commits into from May 21, 2024

Conversation

nitrocode
Copy link
Member

what

  • set minimumReleaseAge

why

  • Do not create PRs upon the first moment of release. Instead, wait X days before proposing to ensure the dependency is stable. If a new version is released in the mean time before the date is passed, the next version release will be proposed instead
  • This can be done at the global level and or at the package level
  • one downside is that people might get anxious that they don't have the latest xyz version in the repo and may rush to propose a dependency update bypassing what's configured in renovate so then we may need to tweak the settings and split it up by package

tests

references

@nitrocode nitrocode closed this Apr 18, 2024
@nitrocode nitrocode reopened this Apr 18, 2024
@nitrocode nitrocode marked this pull request as ready for review April 18, 2024 15:01
@nitrocode nitrocode requested review from a team as code owners April 18, 2024 15:01
@nitrocode nitrocode requested review from chenrui333, lukemassa and X-Guardian and removed request for a team April 18, 2024 15:01
jamengual
jamengual previously approved these changes Apr 18, 2024
@jamengual
Copy link
Contributor

@nitrocode could you fix the conflicts?

@chenrui333 chenrui333 changed the title chore(renovate): set minimumReleaseAge chore(renovate): set minimumReleaseAge for 10 days May 21, 2024
@chenrui333
Copy link
Member

from my perspective the big downside with this is it would potentially ignore the security fixes. cc @runatlantis/maintainers

@jamengual
Copy link
Contributor

maybe we can lower it down to 5 days, but if we do have a security issue, we will release a patch release.

@chenrui333 chenrui333 enabled auto-merge (squash) May 21, 2024 21:47
@chenrui333 chenrui333 changed the title chore(renovate): set minimumReleaseAge for 10 days chore(renovate): set minimumReleaseAge for 5 days May 21, 2024
@chenrui333 chenrui333 merged commit 1d7e42a into main May 21, 2024
28 checks passed
@chenrui333 chenrui333 deleted the renovate-minimumReleaseAge branch May 21, 2024 21:47
ragne pushed a commit to ragne/atlantis that referenced this pull request May 23, 2024
Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
Co-authored-by: Rui Chen <rui@chenrui.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants