feat: add goss testing for the docker image #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jippi
requested review from
jamengual,
nitrocode and
X-Guardian
and removed request for
a team
jippi
force-pushed
the
add-goss-image-testing
branch
from
4c07e71
to
8c13dd1
Compare
nitrocode
reviewed
Apr 19, 2024
nitrocode
reviewed
Apr 19, 2024
jippi
force-pushed
the
add-goss-image-testing
branch
from
8c13dd1
to
172e34c
Compare
|
This PR is up to date and ready for review/merge :) |
|
Anything blocking this from going in? It would have detected a pretty significant regression in Atlantis, and a nice corner stone for further verification of the container images we build down the road :) |
time, is always time to review. |
chenrui333
previously approved these changes
May 19, 2024
chenrui333
reviewed
May 19, 2024
chenrui333
reviewed
May 19, 2024
Co-authored-by: Rui Chen <rui@chenrui.dev>
Co-authored-by: Rui Chen <rui@chenrui.dev>
|
@chenrui333 applied your suggested edits :) |
ragne
pushed a commit
to ragne/atlantis
that referenced
this pull request
May 23, 2024
Co-authored-by: Rui Chen <rui@chenrui.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Adding automatic testing for the container image to avoid regressions like #4439 and #4458
why
Testing is good
tests
Running the tests in CI
references