Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(pr-size): disable message, add files to ignore #4533

Closed
wants to merge 1 commit into from
Closed

ci(pr-size): disable message, add files to ignore #4533

wants to merge 1 commit into from

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented May 10, 2024 •
edited

what

  • disable message
  • add files to ignore

why

  • The message is annoying. My emptying it, according to the upstream code, it should skip commenting PRs.
  • Added some noisy files to ignore

tests

references

@nitrocode nitrocode requested review from a team as code owners May 10, 2024 06:10
@nitrocode nitrocode requested review from GenPage, lukemassa and X-Guardian and removed request for a team May 10, 2024 06:10
@nitrocode nitrocode mentioned this pull request May 10, 2024
Merged
@chenrui333
Copy link
Member

can you test it out in some test repo?

@chenrui333 chenrui333 marked this pull request as draft May 10, 2024 18:27
@chenrui333
Copy link
Member

looks like no longer an issue (as you can see in #4515)

close it for now.

@chenrui333 chenrui333 closed this May 15, 2024
@chenrui333 chenrui333 deleted the pr-size-disable-message branch May 15, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GenPage GenPage Awaiting requested review from GenPage GenPage is a code owner automatically assigned from runatlantis/maintainers

@lukemassa lukemassa Awaiting requested review from lukemassa lukemassa is a code owner automatically assigned from runatlantis/core-contributors

@X-Guardian X-Guardian Awaiting requested review from X-Guardian X-Guardian is a code owner automatically assigned from runatlantis/core-contributors

Assignees
No one assigned
Labels
github-actions size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nitrocode @chenrui333