Skip to content

Commit

Permalink
Add #[derive(Clone, Copy... on all bitflags
Browse files Browse the repository at this point in the history
This will make it easier to use them, e.g. I won't need to re-create `FunctionFlags` for registering multiple similar functions.
  • Loading branch information
nyurik committed Oct 19, 2023
1 parent 476a02a commit 7c58506
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 4 deletions.
1 change: 1 addition & 0 deletions src/config.rs
Expand Up @@ -9,6 +9,7 @@ use crate::{Connection, Result};
/// Database Connection Configuration Options
/// See [Database Connection Configuration Options](https://sqlite.org/c3ref/c_dbconfig_enable_fkey.html) for details.
#[repr(i32)]
#[derive(Copy, Clone, Debug)]
#[allow(non_snake_case, non_camel_case_types)]
#[non_exhaustive]
#[allow(clippy::upper_case_acronyms)]
Expand Down
1 change: 1 addition & 0 deletions src/functions.rs
Expand Up @@ -311,6 +311,7 @@ bitflags::bitflags! {
/// Function Flags.
/// See [sqlite3_create_function](https://sqlite.org/c3ref/create_function.html)
/// and [Function Flags](https://sqlite.org/c3ref/c_deterministic.html) for details.
#[derive(Clone, Copy, Debug)]
#[repr(C)]
pub struct FunctionFlags: ::std::os::raw::c_int {
/// Specifies UTF-8 as the text encoding this SQL function prefers for its parameters.
Expand Down
1 change: 1 addition & 0 deletions src/limits.rs
Expand Up @@ -9,6 +9,7 @@ use std::os::raw::c_int;
/// See the official documentation for more information:
/// - <https://www.sqlite.org/c3ref/c_limit_attached.html>
/// - <https://www.sqlite.org/limits.html>
#[derive(Copy, Clone, Debug)]
#[repr(i32)]
#[non_exhaustive]
#[allow(clippy::upper_case_acronyms, non_camel_case_types)]
Expand Down
2 changes: 1 addition & 1 deletion src/session.rs
Expand Up @@ -655,7 +655,7 @@ impl Connection {
/// See [here](https://sqlite.org/session.html#SQLITE_CHANGESET_CONFLICT) for details.
#[allow(missing_docs)]
#[repr(i32)]
#[derive(Debug, PartialEq, Eq)]
#[derive(Copy, Clone, Debug, PartialEq, Eq)]
#[non_exhaustive]
#[allow(clippy::upper_case_acronyms)]
pub enum ConflictType {
Expand Down
2 changes: 1 addition & 1 deletion src/types/mod.rs
Expand Up @@ -111,7 +111,7 @@ pub struct Null;

/// SQLite data types.
/// See [Fundamental Datatypes](https://sqlite.org/c3ref/c_blob.html).
#[derive(Clone, Debug, PartialEq, Eq)]
#[derive(Copy, Clone, Debug, PartialEq, Eq)]
pub enum Type {
/// NULL
Null,
Expand Down
4 changes: 3 additions & 1 deletion src/vtab/mod.rs
Expand Up @@ -59,6 +59,7 @@ use crate::{str_to_cstring, Connection, Error, InnerConnection, Result};
// ffi::sqlite3_vtab_cursor => VTabCursor

/// Virtual table kind
#[derive(Copy, Clone, Debug)]
pub enum VTabKind {
/// Non-eponymous
Default,
Expand Down Expand Up @@ -322,7 +323,7 @@ pub trait UpdateVTab<'vtab>: CreateVTab<'vtab> {

/// Index constraint operator.
/// See [Virtual Table Constraint Operator Codes](https://sqlite.org/c3ref/c_index_constraint_eq.html) for details.
#[derive(Debug, Eq, PartialEq)]
#[derive(Copy, Clone, Debug, Eq, PartialEq)]
#[allow(non_snake_case, non_camel_case_types, missing_docs)]
#[allow(clippy::upper_case_acronyms)]
pub enum IndexConstraintOp {
Expand Down Expand Up @@ -373,6 +374,7 @@ bitflags::bitflags! {
/// Virtual table scan flags
/// See [Function Flags](https://sqlite.org/c3ref/c_index_scan_unique.html) for details.
#[repr(C)]
#[derive(Copy, Clone, Debug)]
pub struct IndexFlags: ::std::os::raw::c_int {
/// Default
const NONE = 0;
Expand Down
2 changes: 1 addition & 1 deletion src/vtab/series.rs
Expand Up @@ -28,7 +28,7 @@ const SERIES_COLUMN_STOP: c_int = 2;
const SERIES_COLUMN_STEP: c_int = 3;

bitflags::bitflags! {
#[derive(Clone, Copy)]
#[derive(Clone, Copy, Debug)]
#[repr(C)]
struct QueryPlanFlags: ::std::os::raw::c_int {
// start = $value -- constraint exists
Expand Down

0 comments on commit 7c58506

Please sign in to comment.