Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM support #143

Closed
cryptoquick opened this issue Oct 5, 2022 · 7 comments
Closed

WASM support #143

cryptoquick opened this issue Oct 5, 2022 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed upstream Problems related to the upstream code

Comments

@cryptoquick
Copy link
Member

Moving this issue from LNP-BP/client_side_validation#93

stens fails to compile to wasm32-unknown-unknown due to the dependency, amplify_syn.

I can add a WASM test to CI if it can help you resolve this issue, @dr-orlovsky.

@dr-orlovsky
Copy link
Member

CI will be very helpful, thanks! I have not idea how to compile for WASM :)

@cryptoquick cryptoquick mentioned this issue Oct 5, 2022
3 tasks
@cryptoquick
Copy link
Member Author

I can't seem to run my actions against this repo, but I did my best in #144 ... It should work, I think, but I can't know for sure till GH runs them.

@dr-orlovsky dr-orlovsky added good first issue Good for newcomers help wanted Extra attention is needed C-syn upstream Problems related to the upstream code labels Oct 7, 2022
@dr-orlovsky
Copy link
Member

Ok, now I am able to compile to wasm target locally. The error preventing compilation comes not from the amplify crates, but from the upstream:

error[E0433]: failed to resolve: could not find `parse_quote_spanned` in `syn`
   --> /home/orlovsky/.cargo/registry/src/github.com-1ecc6299db9ec823/wasm-bindgen-macro-support-0.2.83/src/parser.rs:110:38

It comes from wasm-bindgen-macro-support which seems to contain a bug. I tried to look into how it can be fixed, but not able to find...

@dr-orlovsky
Copy link
Member

There was a similar issue reported years ago here and it was related to a rust compiler bug: rustwasm/wasm-bindgen#1656

@dr-orlovsky
Copy link
Member

Fixed: it just required to update minimal version of syn. Published to the crates.io

@cryptoquick
Copy link
Member Author

Nice!

@dr-orlovsky
Copy link
Member

Pls let me know if there any other issues preventing RGB on WASM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed upstream Problems related to the upstream code
Projects
Status: Done
Development

No branches or pull requests

2 participants