Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WASM in CI #144

Merged
merged 4 commits into from Oct 7, 2022
Merged

WASM in CI #144

merged 4 commits into from Oct 7, 2022

Conversation

cryptoquick
Copy link
Member

@cryptoquick cryptoquick commented Oct 5, 2022

  • Add wasm-pack and wasm32 target to lint and test in CI.
  • Add caching to most actions to speed up CI builds.
  • Add features needed for wasm-pack to compile to headless chrome.

This PR does not_resolve #143, but it provides the tooling necessary to debug the issues.

…o most actions to speed up CI builds. Add features needed for wasm-pack to compile to headless chrome.
@cryptoquick
Copy link
Member Author

Hm, this PR is actually not running my CI workflow, so I can't test it. Not sure what to do here. Maybe I have to added as a developer to the repo?

@cryptoquick cryptoquick mentioned this pull request Oct 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2022

Codecov Report

Base: 73.3% // Head: 73.3% // No change to project coverage 👍

Coverage data is based on head (08bd441) compared to base (f2e26a9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #144   +/-   ##
======================================
  Coverage    73.3%   73.3%           
======================================
  Files          33      33           
  Lines        5488    5488           
======================================
  Hits         4023    4023           
  Misses       1465    1465           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cryptoquick
Copy link
Member Author

@dr-orlovsky Please also see if this is okay:
cryptoquick#1

I did that because of the error in the linter test:
https://github.com/rust-amplify/rust-amplify/actions/runs/3190687266/jobs/5206524255#step:5:63

@dr-orlovsky
Copy link
Member

I see. Since we can't update edition (pls see rationale in that PR), we have to restrict the max one_cell version to the one before edition upgrade. In fact it is a failure of once_cell maintainers which introduced 2021 edition (which is a breaking change) without major version bump

@cryptoquick
Copy link
Member Author

This apparently blew up in a discussion in the once_cell crate, but I found this:
matklad/once_cell#201 (comment)
Can you try re-running my CI actions again?

@cryptoquick cryptoquick marked this pull request as ready for review October 6, 2022 21:59
@cryptoquick
Copy link
Member Author

Thanks! Looks like the things I'd expect to fail on wasm to fail, except the desktop clippy lints, which I believe found legitimate issues... Can this be merged, then?

@dr-orlovsky dr-orlovsky merged commit 5b4679b into rust-amplify:master Oct 7, 2022
@cryptoquick
Copy link
Member Author

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants