New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASM in CI #144
WASM in CI #144
Conversation
…o most actions to speed up CI builds. Add features needed for wasm-pack to compile to headless chrome.
Hm, this PR is actually not running my CI workflow, so I can't test it. Not sure what to do here. Maybe I have to added as a developer to the repo? |
Codecov ReportBase: 73.3% // Head: 73.3% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #144 +/- ##
======================================
Coverage 73.3% 73.3%
======================================
Files 33 33
Lines 5488 5488
======================================
Hits 4023 4023
Misses 1465 1465 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@dr-orlovsky Please also see if this is okay: I did that because of the error in the linter test: |
I see. Since we can't update edition (pls see rationale in that PR), we have to restrict the max |
This apparently blew up in a discussion in the |
Thanks! Looks like the things I'd expect to fail on wasm to fail, except the desktop clippy lints, which I believe found legitimate issues... Can this be merged, then? |
Awesome! |
This PR does not_resolve #143, but it provides the tooling necessary to debug the issues.