Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support v0.18.x getblockchaininfo with single request #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevenroose
Copy link
Collaborator

Closes #167.

@shesek
Copy link
Contributor

shesek commented Mar 16, 2021

Looks good!

Maybe worth pulling the conversion code for backwards compatibility out of the get_blockchain_info method though, just to keep things more tidy? Most other methods are pretty short, typically a few-liners.

@stevenroose
Copy link
Collaborator Author

Looks good!

Maybe worth pulling the conversion code for backwards compatibility out of the get_blockchain_info method though, just to keep things more tidy? Most other methods are pretty short, typically a few-liners.

Do you like the idea of having a compat::v0_18 module for that? So that we can make them for future versions?

@shesek
Copy link
Contributor

shesek commented Mar 18, 2021

@stevenroose Yes, I like it. More organized and tucked away from the main code.

Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 71fc2b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants