-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update create_wallet for 0.21 #174
base: master
Are you sure you want to change the base?
Conversation
I actually don't think CI failure is a problem with the node we use for testing, it's rather two-fold:
|
I fixed the 1.29.0 CI in #175. Once it's merged can you please rebase on master? I'll try to get it in quickly, sorry for the inconvenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks! like Sebastian said, please rebase :)
a74daba
to
064b923
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 064b923
0.21 added descriptor wallets + the ability to mark wallets for loading on startup.
Descriptor wallets have no "keypool_oldest" parameter, and also never have an HD seed.
Test passed with a node built with descriptor support; I suppose the node used for CI would also need to be built with descriptor support.