Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update create_wallet for 0.21 #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jharveyb
Copy link
Contributor

0.21 added descriptor wallets + the ability to mark wallets for loading on startup.

Descriptor wallets have no "keypool_oldest" parameter, and also never have an HD seed.

Test passed with a node built with descriptor support; I suppose the node used for CI would also need to be built with descriptor support.

@sgeisler
Copy link
Contributor

sgeisler commented May 1, 2021

I actually don't think CI failure is a problem with the node we use for testing, it's rather two-fold:

  • your code does not comply with the formatting standards enforced using rustfmt (see the stable run)
  • we currently have a problem with rust 1.29.0, presumably because a dependency broke MSRV in a minor version 😦 (see the 1.29.0 run) we'll have to look into this and probably fix it by pinning yet another dependency for 1.29.0 testing.

@sgeisler
Copy link
Contributor

sgeisler commented May 2, 2021

I fixed the 1.29.0 CI in #175. Once it's merged can you please rebase on master? I'll try to get it in quickly, sorry for the inconvenience.

Copy link
Collaborator

@stevenroose stevenroose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks! like Sebastian said, please rebase :)

Copy link
Contributor

@sgeisler sgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 064b923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants