Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of Concept: Make tests independent using bitcoind crate and migrate to github actions #183

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RCasatta
Copy link
Collaborator

I think we should migrate to github actions and make integrations tests independent proper #[test] like I have done here with test_get_blockchain_info

Since it's a big refactor, I would like feedback and non-binding pre-approval before continuing

@p0lunin
Copy link

p0lunin commented Aug 1, 2021

bitcoind crate is depend of bitcoincore-rpc. So it is strange to use bitcoind which depends on bitcoincore-rpc to test bitcoincore-rpc. You can just write simple script to initialize bitcoind like i do it here: https://github.com/p0lunin/mint/blob/main/tracker/tests/setup_single_node.sh, https://github.com/p0lunin/mint/blob/main/tracker/tests/regtest_bitcoin_node.rs#L75-L85.

@RCasatta
Copy link
Collaborator Author

RCasatta commented Jan 10, 2022

bitcoind crate is depend of bitcoincore-rpc. So it is strange to use bitcoind which depends on bitcoincore-rpc to test bitcoincore-rpc

that is true, because it's handy for users to have the daemon launched and the rpc client ready to perform requests. However in this MR PoC I don't use the client from the crate but a locally created one, testing current HEAD of rust-bitcoincore-rpc

You can just write simple script to initialize bitcoind like i do it here:

yeah, very similar as the bitcoind crate, I personally prefer to use a crate instead of including source code, as a dev-dep there aren't big security concern I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants