Adds generate_block function to Client
#189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xB10C
reviewed
Aug 25, 2021
| fn generate_block( | ||
| &self, | ||
| output: &Address, | ||
| transactions: &[bitcoin::Txid], |
There was a problem hiding this comment.
Note: As per linked documentation Bitcoin Core accepts both txids and raw transaction in hex here.
Not sure if it's worth going the extra mile to be able to pass raw transaction in hex here too.
There was a problem hiding this comment.
One of the main use cases for the generateblock rpc is to perform a double spend of a tx that is in bitcoind's mempool. In that case a raw transaction is required since bitcoind won't be able to find the tx by txid.
|
You could add an integration test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
generate_blockfunction toClienttype according to the reference page https://developer.bitcoin.org/reference/rpc/generateblock.html.