Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose rand on bitcoin dep as feature #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gregdhill
Copy link
Contributor

Signed-off-by: Gregory Hill gregorydhill@outlook.com

Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
@tcharding
Copy link
Member

Why is this needed please?

@apoelstra
Copy link
Member

Needs rebase.

@tcharding it's a generally useful feature, especially for wallets, and fishing it through this crate lets people use json::bitcoin as their bitcoin dep without needing to keep multiple versions in sync.

@tcharding
Copy link
Member

Yep cool cheers, Tobin from August knew a lot less about dependency management that Tobin today (thanks to rust-bitcoin :)

@tcharding
Copy link
Member

I believe we want this feature, is this PR live still otherwise I an pick it up.

@tcharding tcharding added this to the v0.19.0 milestone Apr 30, 2024
@tcharding tcharding mentioned this pull request May 1, 2024
@tcharding
Copy link
Member

This PR is super old an the repo has changed a lot. I did #342, done differently to this but the same concept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants