Upgrade hashes dependency #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
03-21-upgrade-hashes
branch
from
8b1ecfc
to
54876aa
Compare
|
Just started for the day and at this second I can't remember exactly what I meant to link to. I think I meant to flag the discussion on whether we remove the range dependency all together. |
|
Ah, right. My preferred choice is to merge 686 (dropping the impls on |
|
Aight, I'll sort it out shortly. |
Keep the range versioning but increase the threshould to include the upcoming `v0.14.0` release.
tcharding
force-pushed
the
03-21-upgrade-hashes
branch
from
54876aa
to
645271d
Compare
|
Rebase only, no other changes. |
apoelstra
approved these changes
Mar 28, 2024
|
I'm gonna go ahead and merge this. I'm happy with the work we're doing in other PRs to make this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep the range versioning but increase the threshold to include the latest
v0.14.0release.