Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #644 #645

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #644 #645

wants to merge 1 commit into from

Conversation

barrowsys
Copy link

@barrowsys barrowsys commented Apr 6, 2021 •
edited

fixes #644

love the PR template btw

  • the tests are passing locally with cargo test
  • cookbook renders correctly in mdbook serve -o
  • commits are squashed into one and rebased to latest master
    • merge is handled by the PR, right? image
  • PR contains correct "fixes #ISSUE_ID" clause to autoclose the issue on PR merge
  • spell check runs without errors ./ci/spellcheck.sh
  • link check runs without errors link-checker ./book
    • not sure where to get link-checker?
  • non rendered items are in sorted order (links, reference, identifiers, Cargo.toml)
  • links to docs.rs have wildcard version https://docs.rs/tar/*/tar/struct.Entry.html
  • example has standard error handling
  • code identifiers in description are in hyperlinked backticks

@barrowsys barrowsys marked this pull request as ready for review April 6, 2021 17:58
@barrowsys barrowsys mentioned this pull request Apr 6, 2021
Open
@barrowsys
Copy link
Author

barrowsys commented Apr 6, 2021 •
edited

CI confirms the relevant tests worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

web/clients/download/basic doesnt handle binary files
1 participant
@barrowsys