Skip to content

Commit

Permalink
Remove unused libbacktrace and gimli-symbolize features (#615)
Browse files Browse the repository at this point in the history
  • Loading branch information
Enselic committed May 6, 2024
1 parent eb68d01 commit 4cbe6b6
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Expand Up @@ -73,8 +73,8 @@ jobs:
env:
CARGO_PROFILE_DEV_SPLIT_DEBUGINFO: packed
CARGO_PROFILE_TEST_SPLIT_DEBUGINFO: packed
- run: cargo test --features gimli-symbolize --manifest-path crates/without_debuginfo/Cargo.toml
- run: cargo test --manifest-path crates/line-tables-only/Cargo.toml --features gimli-symbolize
- run: cargo test --manifest-path crates/without_debuginfo/Cargo.toml
- run: cargo test --manifest-path crates/line-tables-only/Cargo.toml

# Test debuginfo compression still works
- run: cargo test
Expand Down
2 changes: 0 additions & 2 deletions Cargo.toml
Expand Up @@ -79,9 +79,7 @@ coresymbolication = []
dbghelp = []
dl_iterate_phdr = []
dladdr = []
gimli-symbolize = []
kernel32 = []
libbacktrace = []
libunwind = []
unix-backtrace = []
verify-winapi = [
Expand Down
4 changes: 0 additions & 4 deletions crates/line-tables-only/Cargo.toml
Expand Up @@ -15,7 +15,3 @@ features = [
'libunwind',
'std',
]

[features]
libbacktrace = ['backtrace/libbacktrace']
gimli-symbolize = ['backtrace/gimli-symbolize']
4 changes: 0 additions & 4 deletions crates/without_debuginfo/Cargo.toml
Expand Up @@ -14,7 +14,3 @@ debug = false

[profile.test]
debug = false

[features]
libbacktrace = ['backtrace/libbacktrace']
gimli-symbolize = ['backtrace/gimli-symbolize']
2 changes: 1 addition & 1 deletion src/symbolize/mod.rs
Expand Up @@ -453,7 +453,7 @@ cfg_if::cfg_if! {
/// While this function is always available it doesn't actually do anything on
/// most implementations. Libraries like dbghelp or libbacktrace do not provide
/// facilities to deallocate state and manage the allocated memory. For now the
/// `gimli-symbolize` feature of this crate is the only feature where this
/// `std` feature of this crate is the only feature where this
/// function has any effect.
#[cfg(feature = "std")]
pub fn clear_symbol_cache() {
Expand Down

0 comments on commit 4cbe6b6

Please sign in to comment.