fix clippy slow_vector_initialization #618
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be smaller codegen size
|
Ahh, this should affect |
|
Why CI ignores changes in workflow? idk. |
| @@ -409,8 +409,7 @@ pub fn init() -> Result<Init, ()> { | |||
| // | |||
| // See https://learn.microsoft.com/cpp/build/reference/pdbpath for an | |||
| // example of where symbols are usually searched for. | |||
| let mut search_path_buf = Vec::new(); | |||
| search_path_buf.resize(1024, 0); | |||
| let mut search_path_buf = vec![0; 1024]; | |||
There was a problem hiding this comment.
Hmm. This could be with_capacity, and then we pass the search_path_buf.capacity() when indicating how much space we have to allocate, and then we pass a search_path_buf.set_len after filling it.
...or that could be over-optimization as we are likely to get a fresh raw page from the OS because this was a calloc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be smaller code size