Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some instances of dead_code #619

Merged
merged 3 commits into from May 6, 2024

Conversation

klensy
Copy link
Contributor

@klensy klensy commented May 4, 2024

No description provided.

Copy link

github-actions bot commented May 4, 2024

Code size changes for a hello-world Rust program linked with libstd with backtrace:

On platform ubuntu-latest:

  • Original binary size: 362,912 B
  • Updated binary size: 362,920 B
  • Difference: 8 B (0%)

@klensy
Copy link
Contributor Author

klensy commented May 4, 2024

Code size changes for a hello-world Rust program linked with libstd with backtrace:

On platform ubuntu-latest:

* Original binary size: **362,912 B**

* Updated binary size: **362,920 B**

* Difference: **8 B** (0%)

Super weird results.

@klensy
Copy link
Contributor Author

klensy commented May 4, 2024

Anyway, second commit reduces Frame size (for non serde, which is used in std):

print-type-size type: `capture::Frame`: 40 bytes, alignment: 8 bytes
print-type-size     discriminant: 8 bytes
print-type-size     variant `Raw`: 32 bytes
print-type-size         field `.0`: 32 bytes
print-type-size     variant `Deserialized`: 32 bytes
print-type-size         field `.ip`: 8 bytes
print-type-size         field `.symbol_address`: 8 bytes
print-type-size         field `.module_base_address`: 16 bytes


print-type-size type: `capture::Frame`: 32 bytes, alignment: 8 bytes
print-type-size     variant `Raw`: 32 bytes
print-type-size         field `.0`: 32 bytes

@workingjubilee
Copy link
Contributor

Thanks!

I'll take a reduction in the actual data structure size yeah, binary size doesn't matter much.

Copy link
Contributor

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@workingjubilee workingjubilee merged commit f63b581 into rust-lang:master May 6, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants