New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests for rust 1.79 #621
Fix tests for rust 1.79 #621
Conversation
The sweet irony of "it won't actually work until its committed". |
I suppose there is a way to fix it, actually... |
e647169
to
9ca9f5d
Compare
Looks good. Are there any docs for |
Btw, it's just check_cfg that's failing. |
It may not be actually deprecated yet but it soon will be
@Urgau It caught like two things that it should have caught and I almost missed them because it was squawking irrelevantly on all the nonsense like |
I didn't design this crate's silliness, I just keep it running. |
@ChrisDenton It looks like there's only one for the associated codegen option: |
Ah, found it: rust-lang/reference#1468 |
Thank you! |
@workingjubilee This crate has already many |
@Urgau I intend to delete this crate's main build.rs, so no. |
@Urgau This crate only has a build.rs because Rust currently has tail-end Android legacy support that is not actually supported anymore upstream by the NDK. So, rust-lang/rust has a PR up to remove it, but that is blocked on rust's own CI. This crate never should have had a build.rs, and that will soon be fixed for good, and I will not merge another. |
collapse_debuginfo
rustup update --no-self-update
consistently to avoid spurious CI errors