Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for rust 1.79 #621

Conversation

workingjubilee
Copy link
Contributor

@workingjubilee workingjubilee commented May 6, 2024

  • Fix the accuracy test for collapse_debuginfo
  • Fix a couple of unexpected_cfgs warnings about Cargo features
  • Silence the rest, ain't nobody got time for all that shit
  • Use rustup update --no-self-update consistently to avoid spurious CI errors

@workingjubilee
Copy link
Contributor Author

The sweet irony of "it won't actually work until its committed".

@workingjubilee
Copy link
Contributor Author

I suppose there is a way to fix it, actually...

@workingjubilee workingjubilee force-pushed the collapse-debuginfo-was-stabilized branch from e647169 to 9ca9f5d Compare May 6, 2024 19:19
@ChrisDenton
Copy link
Contributor

Looks good. Are there any docs for collapse_debuginfo yet?

@ChrisDenton
Copy link
Contributor

Btw, it's just check_cfg that's failing.

@workingjubilee
Copy link
Contributor Author

@Urgau It caught like two things that it should have caught and I almost missed them because it was squawking irrelevantly on all the nonsense like --cfg backtrace_in_libstd.

@workingjubilee
Copy link
Contributor Author

I didn't design this crate's silliness, I just keep it running.

@workingjubilee workingjubilee changed the title Fix accuracy tests for rust 1.79 Fix tests for rust 1.79 May 6, 2024
@workingjubilee
Copy link
Contributor Author

@workingjubilee
Copy link
Contributor Author

Ah, found it: rust-lang/reference#1468

@workingjubilee workingjubilee merged commit eb68d01 into rust-lang:master May 6, 2024
41 checks passed
@ChrisDenton
Copy link
Contributor

Thank you!

@Urgau
Copy link

Urgau commented May 6, 2024

@Urgau It caught like two things that it should have caught and I almost missed them because it was squawking irrelevantly on all the nonsense like --cfg backtrace_in_libstd.

@workingjubilee This crate has already many build.rs, you could have simply added the required cargo::check-check-cfg instructions in it.

@workingjubilee
Copy link
Contributor Author

@Urgau I intend to delete this crate's main build.rs, so no.

@workingjubilee workingjubilee deleted the collapse-debuginfo-was-stabilized branch May 6, 2024 20:25
@workingjubilee
Copy link
Contributor Author

@Urgau This crate only has a build.rs because Rust currently has tail-end Android legacy support that is not actually supported anymore upstream by the NDK. So, rust-lang/rust has a PR up to remove it, but that is blocked on rust's own CI. This crate never should have had a build.rs, and that will soon be fixed for good, and I will not merge another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants