Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toml): remove lib.plugin key support and make it warning #13902

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

heisen-li
Copy link
Contributor

@heisen-li heisen-li commented May 11, 2024

What does this PR try to resolve?

Remove lib.plugin key, making it an "unused key" warning.

Remove some of the tests, which should look useless (I hope I'm understanding this

  • Remove key, and related tests.
  • Adjust the documentation about the plugin.
  • Some of the comments and function names have not yet finished being modified.

part of #13629

Closes #13246

@rustbot
Copy link
Collaborator

rustbot commented May 11, 2024

r? @epage

rustbot has assigned @epage.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2024
@heisen-li heisen-li marked this pull request as draft May 12, 2024 02:43
@heisen-li heisen-li force-pushed the plugin branch 2 times, most recently from feda71e to 3638496 Compare May 13, 2024 09:07
@heisen-li heisen-li marked this pull request as ready for review May 13, 2024 11:15
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you do documentation update as well?

  • src/doc/src/reference/cargo-targets.md could just indicate that “This option is deprecated and unused”.
  • Change this line to “mostly for support of proc-macros”.
  • Any other comments or function names containing "plugin" that needs to be removed. You can hold of this a bit, as it might require extra efforts.

Personally the change is fine, though I still think it is great to ship this along with the version introduction edition 2024 (not tie to edition just merge this in the same version).

tests/testsuite/build_script.rs Show resolved Hide resolved
tests/testsuite/cross_compile.rs Show resolved Hide resolved
@rustbot rustbot added the A-documenting-cargo-itself Area: Cargo's documentation label May 14, 2024
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you squash doc commits into one, and test commits into another?

src/doc/src/reference/cargo-targets.md Show resolved Hide resolved
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It might not be necessary, though I'd like to wait a little longer. I'll merge this once nightly 1.81 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documenting-cargo-itself Area: Cargo's documentation A-manifest Area: Cargo.toml issues S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for rustc plugins
4 participants