Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Query rustc for clang target triples instead of hardcoding them #1004

Merged
merged 9 commits into from
Mar 15, 2024
Merged

feat: Query rustc for clang target triples instead of hardcoding them #1004

merged 9 commits into from
Mar 15, 2024

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Mar 9, 2024

Fixed #994

Add new workspace crate gen-target-info for generating src/target_info.rs, and use it to simplify riscv target arch mapping logic in Build::add_default_flags

@NobodyXu
Add new workspace crate gen-target-info
9d45f70 
For generating `src/target_info.rs`, and use it to simplify
riscv target arch mapping logic in `Build::add_default_flags`

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix msrv CI: Pass --locked to cargo to use constructed lockfile
d6161e8 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix msrv: Use edition 2018 in workspace gen-target-info
6541ea5 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix gen-target-info: Generate formatted rust code
22ef3fe 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Fix gen-target-info
5505ce0 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Format Cargo.toml
f7b04cf 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu marked this pull request as ready for review March 9, 2024 12:45
workingjubilee
workingjubilee requested changes Mar 9, 2024
View reviewed changes
Copy link

@workingjubilee workingjubilee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not entirely sure if this is an improvement, but I am certainly not against it, since it transforms a bunch of logic into data, which is much better to see.

dev-tools/gen-target-info/src/main.rs Outdated Show resolved Hide resolved
dev-tools/gen-target-info/src/write.rs Show resolved Hide resolved
dev-tools/gen-target-info/src/write.rs Outdated Show resolved Hide resolved
src/target_info.rs Show resolved Hide resolved
dev-tools/gen-target-info/src/main.rs Show resolved Hide resolved
@NobodyXu
Rename write_string_mapping_to_file to write_target_tuple_mapping
f1baca9 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Refactor: Extract new fn generate_riscv_arch_mapping
2cc4f4a 
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu
Add doc for the target_info.rs to warn against manually editing the…
2894654 
… file

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu mentioned this pull request Mar 13, 2024
Open
@NobodyXu NobodyXu merged commit abf67d7 into main Mar 15, 2024
42 checks passed
@NobodyXu NobodyXu deleted the feat/query-rustc branch March 15, 2024 01:45
@NobodyXu
Copy link
Collaborator Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@workingjubilee workingjubilee workingjubilee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query rustc for clang target triples
2 participants
@NobodyXu @workingjubilee