Prioritize RUSTC_LINKER over target->cross-compile-prefix table. #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rationale is that if rustc is explicitly instructed to use a specific linker, using it as base for cross-compile prefix would be better aligned with user expectations.
dot-asm
force-pushed
the
prioritize-RUSTC_LINKER
branch
from
48a0f0d
to
52d25a0
Compare
|
Re-based and aligned with recent MSRV adjustment. |
thomcc
approved these changes
Jan 31, 2023
|
I'm going to let it sit shortly since I'd like to test it a little, but will merge it later this week. |
|
Eh, I'll just test it on master when I get to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale is that if rustc is explicitly instructed to use a specific linker, using it as base for cross-compile prefix would be better aligned with user expectations.
This is in response to #766. Should fix #654.