Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some doc comments #792

Merged
merged 2 commits into from
Feb 18, 2023
Merged

Update some doc comments #792

merged 2 commits into from
Feb 18, 2023

Conversation

mqudsi
Copy link
Contributor

@mqudsi mqudsi commented Feb 9, 2023

Super minor, only filing because the nvcc comment was bothering me every time I saw it.

  • Clarify the nvcc behavior documented for push_cc_arg() and reformat its comment.
  • Update the doc comments for functions that handle duplicate flags to clarify that they only check optimization flags at the moment.

* Clarify that the flag is added after other arguments (although obvious from
  the function name),
* Push extraneous info to the second paragraph to display nicer in IDE
  completions,
* Reword the bits about nvcc and the `-Xcompiler` flag.
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JohnTitor JohnTitor merged commit 06c1289 into rust-lang:main Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants