Prevent cloning on every get_xxx() call
#793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomcc
approved these changes
Feb 9, 2023
|
I only changed the one I was using. Happy to update the rest 👍. |
|
I don't think it's super important (these strings are all very small). That said, you feel a desire to anyway, it seems good to be consistent to the ones which are not public API, and exist also as a local. |
They're dereferencing `Arc<String>` variables, but need a fallback in case the variable wasn't set. This implies there's a desire to avoid cloning them everywhere. Return a `Cow<str>` instead of `String`. We never use the allocated results and just compare against them, so there's no need to re-allocate each time.
mqudsi
changed the title
get_host() callget_xxx() call
|
I've changed the other functions. Same case as before with the results of these private functions never being stored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return a
Cow<str>instead ofString. We never use the allocated result and just compare against it, so there's no need to re-allocate each time.