Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gnu -o flag for obj out path instead of -Fo when using gcc & g++ on Windows #820

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

Spencer1O1
Copy link
Contributor

Did the same thing that @datalus did for clang in commit e0d6380ddc038920e01a4778f9e3947bf8f40c30
Resolves issues #800 and #819

Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beginning to feel that we should just pass the compiler family in, rather than having all these checks... Oh well, for now this is fine I suppose.

@Spencer1O1
Copy link
Contributor Author

@thomcc Yes I thought the same thing, but I don't have time to go change everything right now. As long as it works...

@thomcc thomcc merged commit 163eb8e into rust-lang:main Jul 17, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants