Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup mod com, registry, setup_config and winapi #828

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Cleanup mod com, registry, setup_config and winapi #828

merged 1 commit into from
Jul 21, 2023

Conversation

NobodyXu
Copy link
Collaborator

Uses items exported from the official crate windows_sys instead of homebrew definition whenever possible.

Uses items exported from the official crate `windows_sys` instead of
homebrew definition whenever possible.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@thomcc
Copy link
Member

thomcc commented Jul 20, 2023

Are any of the types from windows-rs this adds to public APIs more complex than simple typedefs of primitives?

E.g. would we have to cut a breaking change if we bump the windows-sys version? (That seems unacceptable given how frequently they cut breaking changes)

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Jul 21, 2023

Are any of the types from windows-rs this adds to public APIs more complex than simple typedefs of primitives?

Well there is indeed a few types imported that are not typedefs:

pub use windows_sys::{
    core::GUID,
    Win32::{
        Foundation::FILETIME,
        System::Com::{SAFEARRAY, SAFEARRAYBOUND},
    },
};

E.g. would we have to cut a breaking change if we bump the windows-sys version? (That seems unacceptable given how frequently they cut breaking changes)

No, windows-sys is not used in public interfaces, all changes are to modules that are used internally only.

Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine then.

@thomcc thomcc merged commit 2d9941b into rust-lang:main Jul 21, 2023
16 checks passed
@NobodyXu NobodyXu deleted the remove-winapi branch July 21, 2023 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants