refactor target flags #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@youknowone can you resolve the merge conflict please? |
youknowone
force-pushed
the
refactor-target
branch
from
515e5c0
to
4d24964
Compare
|
@NobodyXu Done |
NobodyXu
approved these changes
Feb 26, 2024
|
Thank you! |
NobodyXu
added a commit
that referenced
this pull request
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Apple architectures have very specific ways of dealing with compiler flags, dividing Apple and the rest of the architecture helps lump similar logic together. We will not have to fix 2 unrelated places for Apple architecture issues anymore.
Now deployment target version is reused for both architecture and target. I didn't finish it here yet, but target handling can be smarter by reusing architecture handling result.