Fix Apple deployment version floor when linking C++ #901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
requested changes
Nov 14, 2023
BlackHoleFox
force-pushed
the
apple-cplusplus-legacy
branch
from
d102cd8
to
188e2a0
Compare
NobodyXu
requested changes
Nov 14, 2023
BlackHoleFox
force-pushed
the
apple-cplusplus-legacy
branch
from
188e2a0
to
0f40f29
Compare
thomcc
approved these changes
Nov 14, 2023
NobodyXu
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says :) This fixes an unfortunate mixture of #848 and #872 so that the baseline version for modern C++ on Apple targets is respected again, so they now link the right C++ stdlib again.
Fixes #900