Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unconditional cargo metadata printing on flag support check #908

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

ahlinc
Copy link
Contributor

@ahlinc ahlinc commented Nov 28, 2023

This PR fixes an issue that if the Build instance configured with disabled cargo metadata production this doesn't have an impact on the internally used Build instance and for every compiler flag check the cargo metadata is still produced and printed to the stdout.

It's expected that the bellow configuration on the client code shouldn't produce any cargo metadata output:

let mut cfg = cc::Build::new();
cfg.cargo_metadata(false);

src/lib.rs Show resolved Hide resolved
@NobodyXu NobodyXu merged commit bfd68f2 into rust-lang:main Nov 29, 2023
17 checks passed
@NobodyXu
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants