Add support for ARM64EC when building with MSVC #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaoliello
force-pushed
the
arm64ec
branch
2 times, most recently
from
5692c65
to
52a3f46
Compare
|
@ChrisDenton would you mind having a look at this PR? It's blocking adding ARM64EC as a new target, and also provides some cleanups to avoid splitting the target triple over-and-over again within |
|
For sure, I'm still catching up on review but I'll prioritize this. |
ChrisDenton
approved these changes
Jan 5, 2024
| instance_path: &Path, | ||
| ) -> Option<(PathBuf, PathBuf, PathBuf, PathBuf, PathBuf)> { | ||
| ) -> Option<(PathBuf, PathBuf, PathBuf, PathBuf, Option<PathBuf>, PathBuf)> { |
There was a problem hiding this comment.
I think this return type is getting increasingly out of hand and should probably be a proper struct or otherwise rearchitectured. However, vs15plus_vc_paths is only called from one place and that immediately deconstructs it into named variables so I'm not minded to block this PR on that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-arm64ECflag to cl.exe and/machine:arm64ecto lib.exe: https://learn.microsoft.com/en-us/windows/arm/arm64ec-build#developer-command-promptarm64ecas a target arch by using theaarch64paths.arm64ecthe lib path must ALSO include thearm64ecVC libs BEFORE theaarch64libs.TargetArchwrapper type to avoid splitting the target string multiple times or callingcontainswhen we could be using string comparison.