Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for riscv32imac-esp-espidf #939

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add support for riscv32imac-esp-espidf #939

merged 1 commit into from
Jan 31, 2024

Conversation

madmo
Copy link
Contributor

@madmo madmo commented Jan 30, 2024

esp32c6 and esp32h2 use the riscv32imac-esp-espidf target

Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks lgtm, but I'm not very familiar with riscv targets, so I would also like review from *-esp-espidf target maintainers @ivmarkov @MabezDev

@ivmarkov
Copy link

Hmmm, let me take a deeper look tomorrow. For one, I don't see there a definition of the older riscv32imc-esp-espidf target (which is used for esp32c3). Or am I blind? :)

@madmo Can you elaborate a bit what is your use case?

@madmo
Copy link
Contributor Author

madmo commented Jan 31, 2024

Hmmm, let me take a deeper look tomorrow. For one, I don't see there a definition of the older riscv32imc-esp-espidf target (which is used for esp32c3). Or am I blind? :)

@madmo Can you elaborate a bit what is your use case?

@ivmarkov riscv32imc-esp-espidf is some 10 lines down in the same file, but was already there. Probably because the c3 was released way earlier.

Sure, my use case is that I have a cargo based esp32c6 project which is mostly rust code 🥳. For some tiny functionality I want to re use a existing single file C library. Switching the whole project to a CMake based build feels overkill.

@ivmarkov
Copy link

Hmmm, let me take a deeper look tomorrow. For one, I don't see there a definition of the older riscv32imc-esp-espidf target (which is used for esp32c3). Or am I blind? :)
@madmo Can you elaborate a bit what is your use case?

@ivmarkov riscv32imc-esp-espidf is some 10 lines down in the same file, but was already there. Probably because the c3 was released way earlier.

@madmo Ah yes, I'm blind indeed. :)

If I could ask you a favor: while we are at it, would you mind extending your PR to also include mapping for the riscv32imafc-esp-espidf target as well? This target was upstreamed recently, but we forgot about cc-rs there as well. Thanks in advance!

Sure, my use case is that I have a cargo based esp32c6 project which is mostly rust code 🥳. For some tiny functionality I want to re use a existing single file C library. Switching the whole project to a CMake based build feels overkill.

@NobodyXu I'm fine with the change - and as per above - I would also suggest we upstream support for the riscv32imafc-esp-espidf too.

@NobodyXu NobodyXu merged commit b37f836 into rust-lang:main Jan 31, 2024
18 checks passed
@NobodyXu
Copy link
Collaborator

Thank you @madmo @ivmarkov !

and as per above - I would also suggest we upstream support for the riscv32imafc-esp-espidf too.

I would accept a separate PR adding support to it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants