Fix default deployment target behavior for Apple targets #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hindsight defaulting to rustc's default deployment targets when no explicit ones were provided wasn't a great call. Those versions are older then what most people target and interact badly with third-party C libraries and Apple's SDKs that expect usually higher versions instead. So this goes ahead and reverts to
cc's older behavior of using the target's current platform SDKDefaultDeploymentTargetwhen no explicit version is given tocc.This afaict is functionally identical to passing nothing and letting
clangfigure out the default except this keeps the code cleaner because optionals don't need handled everywhere :)Fixes #902