Support native ARM64 MSVC toolchain, and fallback to x64 if emulation is available #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaoliello
commented
Feb 21, 2024
NobodyXu
requested changes
Feb 21, 2024
dpaoliello
force-pushed
the
nativearm64
branch
2 times, most recently
from
41f9b14
to
942d416
Compare
NobodyXu
requested changes
Feb 22, 2024
dpaoliello
force-pushed
the
nativearm64
branch
from
942d416
to
a8586d7
Compare
NobodyXu
requested changes
Feb 22, 2024
dpaoliello
force-pushed
the
nativearm64
branch
2 times, most recently
from
40defd6
to
0b1309a
Compare
NobodyXu
requested changes
Feb 23, 2024
dpaoliello
force-pushed
the
nativearm64
branch
from
0b1309a
to
bed9e3b
Compare
3 tasks
riking
reviewed
Mar 15, 2024
| /// SAFETY: The caller must ensure that the function signature matches the actual function. | ||
| /// The easiest way to do this is to add an entry to windows_sys_no_link.list and use the | ||
| /// generated function for `func_signature`. | ||
| unsafe fn get_proc_address<F>(&self, name: &[u8]) -> Option<F> { |
There was a problem hiding this comment.
This should be tying the lifetime of F to the lifetime of self, if any.
There was a problem hiding this comment.
Thanks, opened #1010 to update safety comment for the function.
I can't add lifetime to the return type directly, I can only add bound to the generic F.
However, I don't think we can add lifetime to function pointer, a newtype that dereferences to F would have the same problem since function pointer is copyable, so the only option is to add a safety comment for this unsafe function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS 17.4 introduced a native ARM64 toolchain (https://devblogs.microsoft.com/visualstudio/arm64-visual-studio-is-officially-here/), and Windows 11 supports running x64 binaries on ARM64 devices.
As such, we should try to use the ARM64 toolchain if it is available, fallback to x64 if support is available on the device (as performance is better than x86) and use x86 as a last resort.
This supersedes #732 (but thanks to @Alovchin91 for working on that PR, as it is the basis for this PR).
Tested on a Surface Pro X running Windows 11.