fix: remove unnecessary printlns

[amaanq]

It seems like it was probably for debugging, but should've been removed before #931 was merged.

Thanks!

[NobodyXu]

How about we turn them into warnings?

They are quite useful when debugging

[amaanq]

The problem is in tree-sitter we use cc to build binary artifacts (parsers) at runtime here, so every single time a user makes a change in their parser this message pops up and is quite annoying. If it were a warning, would that be configurable in any way?

[NobodyXu]

If it were a warning, would that be configurable in any way?

yes, Build::cargo_warning can disable it.

[amaanq]

perfect! should I just edit it to have an if cargo_output.warnings check for each case and print if so?

[NobodyXu]

You just need to use cargo_output: &CargoOutput,, it will handle it for you (you'll need to add it to params of wait_on_child)

[amaanq]

fixed

[NobodyXu]

Thank you!

[amaanq]

Thanks a ton for the quick reviewing!!

[amaanq]

Just a small request, if we could have a minor release somewhat soon that'd be really nice for tree-sitter to also have a minor patch bump as well to get rid of this intrusive runtime logging 😁

[NobodyXu]

I can cut a new release in one week, given that we already got one release this week.

[amaanq]

that works great, thank you

[NobodyXu]

Turns out that we need another logging level for such information.

[amaanq]

I think that might be a good idea, to be honest I still sorta doubt the usefulness of logging what's running and the output status code, but I can see why it might be nice to have. Do you think a debug level better suits this?

[NobodyXu]

I suppose we just add another function debugging_print(bool) to disable it, specifically for your ise case.

It will be printed without cargo:warnings= just like how it was before this PR, but allows you to disable it to get back the old behavior.

[amaanq]

Alright I've put up #972, I think that debug logging should be disabled by default - let's continue the conversation there