Use llvm-ar, llvm-ranlib for Android NDK #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NobodyXu
requested changes
Mar 1, 2024
NobodyXu
requested changes
Mar 1, 2024
Co-authored-by: Jiahao XU <Jiahao_XU@outlook.com>
NobodyXu
approved these changes
Mar 2, 2024
Amanieu
approved these changes
Mar 2, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For newer Android NDK,
target-triple-ar|ranlibhas been replaced tollvm-ar|ranlib. Which could be an issue when compiling libs like https://github.com/sfackler/rust-openssl .This PR tries to use
llvm-ar|ranlibwhen the compiler family isClang.