-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
async LineWriter
fix #2131
#2477
Merged
taiki-e
merged 9 commits into
rust-lang:master
from
FelipeLema:like_std_io_LineWriter-2131
Oct 8, 2021
Merged
async LineWriter
fix #2131
#2477
taiki-e
merged 9 commits into
rust-lang:master
from
FelipeLema:like_std_io_LineWriter-2131
Oct 8, 2021
Commits on Aug 20, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 54743e6 - Browse repository at this point
Copy the full SHA 54743e6View commit details
Commits on Aug 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0fd0e5e - Browse repository at this point
Copy the full SHA 0fd0e5eView commit details
Commits on Aug 22, 2021
-
doing so saves me thinking on how to deal with pin and fields
Configuration menu - View commit details
-
Copy full SHA for 5667198 - Browse repository at this point
Copy the full SHA 5667198View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2d4356 - Browse repository at this point
Copy the full SHA c2d4356View commit details
Commits on Aug 23, 2021
-
- translate `std::io::LineWriter`'s unit test - rename `inner` field to `buf_writer` to avoid confusion with `BufWriter::inner` - the above lead me to re-write the logic accordingly - add methods to access `buf_writer`'s fields - sorting out types, cannot compile for now
Configuration menu - View commit details
-
Copy full SHA for d019027 - Browse repository at this point
Copy the full SHA d019027View commit details
Commits on Aug 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 50a6095 - Browse repository at this point
Copy the full SHA 50a6095View commit details
Commits on Aug 29, 2021
-
- default `poll_write_vectored` behaves differently of `std::io::LineWriter::write_vectored` - ported from https://github.com/rust-lang/rust/blob/673d0db5e393e9c64897005b470bfeb6d5aec61b/library/std/src/io/buffered/tests.rs - that code has lots of comments, you may wanna check it out - translated tests for `std` 's `line_vectored` - added `inner_poll_write_vectored` to keep code explicit and verbose
Configuration menu - View commit details
-
Copy full SHA for 1163848 - Browse repository at this point
Copy the full SHA 1163848View commit details -
Configuration menu - View commit details
-
Copy full SHA for fadf686 - Browse repository at this point
Copy the full SHA fadf686View commit details
Commits on Sep 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for dbb3ec1 - Browse repository at this point
Copy the full SHA dbb3ec1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.