Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freebsd kinfo_kstat/sigtramp additions #2766

Closed
wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@Amanieu
Copy link
Member

Amanieu commented Apr 28, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Apr 28, 2022

📌 Commit 6fe5534 has been approved by Amanieu

bors added a commit that referenced this pull request Apr 28, 2022
freebsd kinfo_kstat/sigtramp additions
@bors
Copy link
Contributor

bors commented Apr 28, 2022

⌛ Testing commit 6fe5534 with merge f0b6039...

@bors
Copy link
Contributor

bors commented Apr 28, 2022

💔 Test failed - checks-actions

pub struct kinfo_kstack {
pub kkst_tid: ::lwpid_t,
pub kkst_state: ::c_int,
pub kkst_trace: [[::c_char; 32]; 32],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather keep the original size and just use a cfg() to only make this type available on newer rustc versions.

@Amanieu
Copy link
Member

Amanieu commented Apr 29, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Apr 29, 2022

📌 Commit e29e642 has been approved by Amanieu

@Amanieu
Copy link
Member

Amanieu commented Apr 29, 2022

@bors r-

@Amanieu
Copy link
Member

Amanieu commented Apr 29, 2022

Wait, this isn't the right cfg. It seems that we don't have one for this specific feature. Basically in 1.47 most traits were updated to be implemented for arrays of any length. Add a new cfg in build.rs for this.

@devnexen
Copy link
Contributor Author

ah ok will do :)

@Amanieu
Copy link
Member

Amanieu commented May 5, 2022

@bors r+

@bors
Copy link
Contributor

bors commented May 5, 2022

📌 Commit 4b61ce8 has been approved by Amanieu

@bors
Copy link
Contributor

bors commented May 5, 2022

⌛ Testing commit 4b61ce8 with merge 67f4cde...

bors added a commit that referenced this pull request May 5, 2022
freebsd kinfo_kstat/sigtramp additions
@bors
Copy link
Contributor

bors commented May 5, 2022

💔 Test failed - checks-cirrus-freebsd-11

@Amanieu
Copy link
Member

Amanieu commented May 5, 2022

@bors retry

bors added a commit that referenced this pull request May 5, 2022
freebsd kinfo_kstat/sigtramp additions
@bors
Copy link
Contributor

bors commented May 5, 2022

⌛ Testing commit 4b61ce8 with merge 5758b11...

@bors
Copy link
Contributor

bors commented May 5, 2022

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

To revive the logs, @bors try

@bors
Copy link
Contributor

bors commented Sep 12, 2022

⌛ Trying commit 4b61ce8 with merge 0297a34...

bors added a commit that referenced this pull request Sep 12, 2022
freebsd kinfo_kstat/sigtramp additions
@bors
Copy link
Contributor

bors commented Sep 12, 2022

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 13, 2022

📌 Commit 1d20fd1 has been approved by JohnTitor

It is now in the queue for this repository.

bors added a commit that referenced this pull request Sep 13, 2022
freebsd kinfo_kstat/sigtramp additions
@bors
Copy link
Contributor

bors commented Sep 13, 2022

⌛ Testing commit 1d20fd1 with merge b11d467...

@bors
Copy link
Contributor

bors commented Sep 13, 2022

💔 Test failed - checks-actions

@bors
Copy link
Contributor

bors commented Feb 5, 2023

☔ The latest upstream changes (presumably #3101) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnTitor
Copy link
Member

@devnexen Are you still working on this?

@devnexen
Copy link
Contributor Author

@devnexen Are you still working on this?

No I do not think so.

@devnexen devnexen closed this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants