Enable copy_file_range on FreeBSD #3023
Merged
+11
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
|
cc @devnexen |
PR rust-lang#2479 did this, but only in the freebsd13 and freebsd14 modules, which was incorrect. Those modules should only be used for functions that change across FreeBSD versions, and therefore need different ELF symbol versions. Functions that were newly added since FreeBSD 11 can still go in the base freebsd module. It will cause no problems for them to be there, and users will see an error at link time if they try to use such a function in an environment that is too old to support it.
asomers
force-pushed
the
copy_file_range
branch
from
e5fd29b to
5756980
Compare
|
This should fix CI on FreeBSD 12 |
JohnTitor
approved these changes
Nov 30, 2022
|
Makes sense! @bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
valpackett
added a commit
to valpackett/libc
that referenced
this pull request
Feb 11, 2023
According to rust-lang#3023, new ABI did not need to be hidden away under cfg(freebsdXX) flags, only changed ABI!
valpackett
added a commit
to valpackett/libc
that referenced
this pull request
Feb 11, 2023
According to rust-lang#3023, new ABI did not need to be hidden away under cfg(freebsdXX) flags, only changed ABI!
bors
added a commit
that referenced
this pull request
Feb 12, 2023
FreeBSD: move all new ABI to base module, add more O_ flags So according to #3023 all of that stuff didn't need to be hidden away in these conditionally built modules and we could've been exposing `eventfd`, `getrandom`, `getentropy`, `setproctitle_fast` etc. to crates.io consumers all this time… While in the test file, clean up the mess in `skip_fn` :) Other thing we need to expose is `O_PATH`, `O_RESOLVE_BENEATH` for crates like cap-std/openat. While here, add other open flags.
tatref
pushed a commit
to tatref/libc
that referenced
this pull request
Mar 20, 2023
According to rust-lang#3023, new ABI did not need to be hidden away under cfg(freebsdXX) flags, only changed ABI!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2479 did this, but only in the freebsd13 and freebsd14 modules, which was incorrect. Those modules should only be used for functions that change across FreeBSD versions, and therefore need different ELF symbol versions. Functions that were newly added since FreeBSD 11 can still go in the base freebsd module. It will cause no problems for them to be there, and users will see an error at link time if they try to use such a function in an environment that is too old to support it.