membarrier flags constants addition #3039

devnexen · 2022-12-17T18:52:31Z

No description provided.

rustbot · 2022-12-17T18:52:35Z

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

JohnTitor · 2022-12-20T09:55:50Z

Thank you! @bors r+

bors · 2022-12-20T09:55:52Z

📌 Commit ff9fd20 has been approved by JohnTitor

It is now in the queue for this repository.

bors · 2022-12-20T09:56:05Z

⌛ Testing commit ff9fd20 with merge 40024e4...

membarrier flags constants addition

bors · 2022-12-20T10:07:47Z

💔 Test failed - checks-actions

JohnTitor · 2023-01-05T10:37:32Z

Seems our musl image is too old, again 😢 Feel free to ignore them on musl.

   cargo:warning=/checkout/target/mipsel-unknown-linux-musl/debug/build/libc-test-c30ad3b5c559e4de/out/main.c:25965:87: error: 'MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ' undeclared here (not in a function); did you mean 'MEMBARRIER_CMD_PRIVATE_EXPEDITED'?
  cargo:warning=             static const int __test_const_MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ_val = MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ;
  cargo:warning=                                                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cargo:warning=                                                                                       MEMBARRIER_CMD_PRIVATE_EXPEDITED
  cargo:warning=/checkout/target/mipsel-unknown-linux-musl/debug/build/libc-test-c30ad3b5c559e4de/out/main.c:25971:96: error: 'MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ' undeclared here (not in a function); did you mean 'MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED'?
  cargo:warning=             static const int __test_const_MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ_val = MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ;
  cargo:warning=                                                                                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cargo:warning=                                                                                                MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED
  cargo:warning=cc1: error: unrecognized command line option '-Wno-unknown-warning-option' [-Werror]
  cargo:warning=cc1: error: unrecognized command line option '-Wno-address-of-packed-member' [-Werror]

JohnTitor · 2023-01-08T20:20:00Z

@bors r+

bors · 2023-01-08T20:20:01Z

📌 Commit 1c918f0 has been approved by JohnTitor

It is now in the queue for this repository.

membarrier flags constants addition

bors · 2023-01-08T22:18:30Z

⌛ Testing commit 1c918f0 with merge 7b5f915...

bors · 2023-01-08T22:31:47Z

💔 Test failed - checks-actions

JohnTitor · 2023-01-28T02:29:29Z

The failure seems valid:

  cargo:warning=/checkout/target/i686-linux-android/debug/build/libc-test-6f0facd5549984ca/out/main.c:33547:87: error: use of undeclared identifier 'MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ'; did you mean 'MEMBARRIER_CMD_PRIVATE_EXPEDITED'?
  cargo:warning=            static const int __test_const_MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ_val = MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ;
  cargo:warning=                                                                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cargo:warning=                                                                                      MEMBARRIER_CMD_PRIVATE_EXPEDITED
  cargo:warning=/android/ndk-i686/bin/../sysroot/usr/include/linux/membarrier.h:26:3: note: 'MEMBARRIER_CMD_PRIVATE_EXPEDITED' declared here
  cargo:warning=  MEMBARRIER_CMD_PRIVATE_EXPEDITED = (1 << 3),
  cargo:warning=  ^
  cargo:warning=/checkout/target/i686-linux-android/debug/build/libc-test-6f0facd5549984ca/out/main.c:33553:96: error: use of undeclared identifier 'MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ'; did you mean 'MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED'?
  cargo:warning=            static const int __test_const_MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ_val = MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ;
  cargo:warning=                                                                                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cargo:warning=                                                                                               MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED
  cargo:warning=/android/ndk-i686/bin/../sysroot/usr/include/linux/membarrier.h:27:3: note: 'MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED' declared here
  cargo:warning=  MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED = (1 << 4),
  cargo:warning=  ^
  cargo:warning=2 errors generated.

JohnTitor · 2023-01-28T13:42:51Z

@bors r+

bors · 2023-01-28T13:42:52Z

📌 Commit f506ab9 has been approved by JohnTitor

It is now in the queue for this repository.

bors · 2023-01-28T13:43:00Z

⌛ Testing commit f506ab9 with merge bed7e79...

membarrier flags constants addition

bors · 2023-01-28T13:55:55Z

💔 Test failed - checks-actions

JohnTitor · 2023-02-22T08:41:25Z

libc-test/build.rs

@@ -1768,6 +1769,8 @@ fn test_android(target: &str) {
            // GRND_INSECURE was added in platform-tools-30.0.0
            "GRND_INSECURE" => true,

+            "MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_RSEQ" | "MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ" => true,


A comment explaining why it's ignored would be helpful.

JohnTitor · 2023-02-22T08:41:34Z

libc-test/build.rs

+            if name.starts_with("MEMBARRIER_CMD_REGISTER")
+                || name.starts_with("MEMBARRIER_CMD_PRIVATE")
+            {
+                return true;
+            }


JohnTitor · 2023-03-03T11:37:24Z

@bors r+

bors · 2023-03-03T11:37:27Z

📌 Commit 279d932 has been approved by JohnTitor

It is now in the queue for this repository.

bors · 2023-03-03T12:09:15Z

⌛ Testing commit 279d932 with merge b8e2476...

bors · 2023-03-03T13:08:37Z

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing b8e2476 to master...

bors · 2023-03-03T13:08:37Z

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing b8e2476 to master...

bors · 2023-03-03T13:08:41Z

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

rustbot assigned JohnTitor Dec 17, 2022

rustbot added the S-waiting-on-review label Dec 17, 2022

devnexen force-pushed the membarrier_flags_linux branch 3 times, most recently from 34c46a6 to ff9fd20 Compare December 17, 2022 19:38

JohnTitor approved these changes Dec 20, 2022

View reviewed changes

bors added S-waiting-on-bors and removed S-waiting-on-review labels Dec 20, 2022

bors added a commit that referenced this pull request Dec 20, 2022

Auto merge of #3039 - devnexen:membarrier_flags_linux, r=JohnTitor

40024e4

membarrier flags constants addition

bors added S-waiting-on-review and removed S-waiting-on-bors labels Dec 20, 2022

JohnTitor added S-waiting-on-author and removed S-waiting-on-review labels Jan 5, 2023

devnexen force-pushed the membarrier_flags_linux branch from ff9fd20 to 1c918f0 Compare January 5, 2023 18:48

bors added S-waiting-on-bors and removed S-waiting-on-author labels Jan 8, 2023

bors added a commit that referenced this pull request Jan 8, 2023

Auto merge of #3039 - devnexen:membarrier_flags_linux, r=JohnTitor

7b5f915

membarrier flags constants addition

bors added S-waiting-on-review and removed S-waiting-on-bors labels Jan 8, 2023

JohnTitor removed the S-waiting-on-review label Jan 28, 2023

JohnTitor added the S-waiting-on-author label Jan 28, 2023

devnexen force-pushed the membarrier_flags_linux branch from 1c918f0 to f506ab9 Compare January 28, 2023 09:01

JohnTitor approved these changes Jan 28, 2023

View reviewed changes

bors added S-waiting-on-bors and removed S-waiting-on-author labels Jan 28, 2023

bors added a commit that referenced this pull request Jan 28, 2023

Auto merge of #3039 - devnexen:membarrier_flags_linux, r=JohnTitor

bed7e79

membarrier flags constants addition

bors added S-waiting-on-review and removed S-waiting-on-bors labels Jan 28, 2023

devnexen force-pushed the membarrier_flags_linux branch from f506ab9 to 22f819d Compare January 28, 2023 14:22

JohnTitor reviewed Feb 22, 2023

View reviewed changes

membarrier flags constants addition

279d932

devnexen force-pushed the membarrier_flags_linux branch from 22f819d to 279d932 Compare February 22, 2023 22:22

bors added S-waiting-on-bors and removed S-waiting-on-review labels Mar 3, 2023

bors merged commit b8e2476 into rust-lang:master Mar 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

membarrier flags constants addition #3039

membarrier flags constants addition #3039

devnexen commented Dec 17, 2022

rustbot commented Dec 17, 2022

JohnTitor commented Dec 20, 2022

bors commented Dec 20, 2022

bors commented Dec 20, 2022

bors commented Dec 20, 2022

JohnTitor commented Jan 5, 2023

JohnTitor commented Jan 8, 2023

bors commented Jan 8, 2023

bors commented Jan 8, 2023

bors commented Jan 8, 2023

JohnTitor commented Jan 28, 2023

JohnTitor commented Jan 28, 2023

bors commented Jan 28, 2023

bors commented Jan 28, 2023

bors commented Jan 28, 2023

JohnTitor Feb 22, 2023

JohnTitor Feb 22, 2023

JohnTitor commented Mar 3, 2023

bors commented Mar 3, 2023

bors commented Mar 3, 2023

bors commented Mar 3, 2023

bors commented Mar 3, 2023

bors commented Mar 3, 2023

membarrier flags constants addition #3039

membarrier flags constants addition #3039

Conversation

devnexen commented Dec 17, 2022

rustbot commented Dec 17, 2022

JohnTitor commented Dec 20, 2022

bors commented Dec 20, 2022

bors commented Dec 20, 2022

bors commented Dec 20, 2022

JohnTitor commented Jan 5, 2023

JohnTitor commented Jan 8, 2023

bors commented Jan 8, 2023

bors commented Jan 8, 2023

bors commented Jan 8, 2023

JohnTitor commented Jan 28, 2023

JohnTitor commented Jan 28, 2023

bors commented Jan 28, 2023

bors commented Jan 28, 2023

bors commented Jan 28, 2023

JohnTitor Feb 22, 2023

Choose a reason for hiding this comment

JohnTitor Feb 22, 2023

Choose a reason for hiding this comment

JohnTitor commented Mar 3, 2023

bors commented Mar 3, 2023

bors commented Mar 3, 2023

bors commented Mar 3, 2023

bors commented Mar 3, 2023

bors commented Mar 3, 2023