Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: add additional netlink interface attribute tags #3053

Merged
merged 2 commits into from
Jan 22, 2023
Merged

linux: add additional netlink interface attribute tags #3053

merged 2 commits into from
Jan 22, 2023

Conversation

tones111
Copy link
Contributor

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Dec 26, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information.

@tones111
Copy link
Contributor Author

It looks like this change depends on a newer version of linux api headers than what the CI is using. What kernel version is the libc crate attempting to target?

@JohnTitor
Copy link
Member

What kernel version is the libc crate attempting to target?

You could check it at https://github.com/rust-lang/libc/tree/master/ci/docker and related files under the ci dir.
Anyway, it's totally fine to skip tests for them until we bump the image. Could you add the consts here with a comment?

libc/libc-test/build.rs

Line 3385 in 72fba0e

cfg.skip_const(move |name| {

@tones111
linux: add additional netlink interface attribute tags
ea66c05 
IFLA_PARENT_DEV_* were added in linux v5.13
linux: 00e77ed8e64d5f271c1f015c7153545980d48a76

IFLA_GRO_MAX_SIZE was added in linux v5.16
linux: eac1b93c14d645ef147b049ace0d5230df755548

IFLA_TSO_MAX_* were added in linux v5.18
linux: 89527be8d8d672773eeaec910118a6e84fb597e3

IFLA_ALLMULTI was added in linux v6.0
linux: 7e6e1b57162ed6a2d32d2f0929c27d79482ff706
@JohnTitor
Copy link
Member

Thank you! @bors r+

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 18, 2023

📌 Commit ea66c05 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 18, 2023

⌛ Testing commit ea66c05 with merge 00d1697...

bors added a commit that referenced this pull request Jan 18, 2023
@bors
Auto merge of #3053 - tones111:rtnl_if_attr_tags, r=JohnTitor
00d1697 
linux: add additional netlink interface attribute tags
@bors
Copy link
Contributor

bors commented Jan 18, 2023

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 22, 2023

📌 Commit 8b91201 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jan 22, 2023

⌛ Testing commit 8b91201 with merge 0c1079d...

@bors
Copy link
Contributor

bors commented Jan 22, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 0c1079d to master...

@bors bors merged commit 0c1079d into rust-lang:master Jan 22, 2023
@tones111 tones111 deleted the rtnl_if_attr_tags branch January 23, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tones111 @rustbot @JohnTitor @bors