mac time.h functions

[shua]

I used these in https://github.com/shua/graf because I'm used to them, and don't really want to pull in time or chrono just for some stuff already present in libc.h . Compilation worked fine on my linux target, but failed on mac osx because these weren't defined in rust-lang/libc (but these are all present in 13.1 SDK).

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[shua]

It's currently failing because the new functions are unused, but I don't know how to fix this. I'm not sure why these functions are unused but the others are considered to be used. I tried git grep for some of the other functions defined in src/unix/bsd/apple/mod.rs but never found where they're being used, only where they're defined.

[JohnTitor]

Because they're already defined and available on macOS via reexports:

libc/src/unix/mod.rs

Line 1269 in bac1442

pub fn localtime(time_p: *const time_t) -> *mut tm;

Have you tried importing them actually? I'd recommend checking if an item is available at first so that you could confirm what's missing :)

[shua]

ah, thanks, I misunderstood the errors. I updated the PR to remove the time.h functions and struct that were already defined in src/unix/mod.rs and src/unix/linux_like/mod.rs..

[shua]

@rustbot review

[rustbot]

Error: The feature shortcut is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

[shua]

@JohnTitor are you the right person to ask for a review on this?

[JohnTitor]

Yeah, could you squash commits into one?

[shua]

The test failure seems unrelated to my changes. The test that failed was targeting freebsd 14, but my changes only touched two files, both specific to macos. I can try recommitting the same changes to retest.

[JohnTitor]

It's fixed on master :)
@bors r+

[bors]

📌 Commit 78244fe has been approved by JohnTitor

It is now in the queue for this repository.

[bors]

⌛ Testing commit 78244fe with merge b6c2e00...

[bors]

💔 Test failed - checks-actions

[JohnTitor]

@bors retry timeout

[bors]

⌛ Testing commit 78244fe with merge 6b7643d...

[bors]

💔 Test failed - checks-actions

[JohnTitor]

@bors retry

[bors]

⌛ Testing commit 78244fe with merge 4c0ff2c...

[bors]

💔 Test failed - checks-actions

[JohnTitor]

cursed 😱
@bors retry

[bors]

⌛ Testing commit 78244fe with merge 177857b...

[bors]

💔 Test failed - checks-actions

[JohnTitor]

@bors retry

[bors]

⌛ Testing commit 78244fe with merge 21d90af...

[bors]

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 21d90af to master...

[bors]

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 21d90af to master...

[bors]

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.