Linux madv

[tatref]

This is a followup of #2818

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[JohnTitor]

CI failed, could you check?

[tatref]

Sorry, but I'm not sure how to fix this.
I can't find any folder under semver related to Docker

Am I missing something?

[tatref]

Error message:

warning: /checkout/target/i686-unknown-linux-gnu/debug/build/libc-test-a07c148a50447aab/out/main.c:10614:70: error: 'MADV_DONTNEED_LOCKED' undeclared here (not in a function); did you mean 'MADV_DONTNEED'?
warning: 10614 |             static const int __test_const_MADV_DONTNEED_LOCKED_val = MADV_DONTNEED_LOCKED;
warning:       |                                                                      ^~~~~~~~~~~~~~~~~~~~
warning:       |                                                                      MADV_DONTNEED

Seems like MADV_DONTNEED_LOCKED was added in Linux 5.18. If the host image is the same as the container (Ubuntu 22.04), then it comes with Linux 5.15, so the error is expected.

I added it to libc-test/build.rs under cfg.skip_const.
@JohnTitor is this correct?

[JohnTitor]

Yeah, right. Thank you!

[JohnTitor]

@bors r+

[bors]

📌 Commit 6cceb04 has been approved by JohnTitor

It is now in the queue for this repository.

[bors]

⌛ Testing commit 6cceb04 with merge aca7a38...

[bors]

💔 Test failed - checks-actions

[tatref]

Not sure why CI worked, but bors failed on musl.
I excluded a few more items for musl

[JohnTitor]

Note that CI on PR doesn't run all the jobs but bors does the full test.
@bors r+

[bors]

📌 Commit 7d93bb0 has been approved by JohnTitor

It is now in the queue for this repository.

[bors]

⌛ Testing commit 7d93bb0 with merge 05ef4ab...

[bors]

💔 Test failed - checks-cirrus-freebsd-14

[bors]

⌛ Testing commit d95bde7 with merge d707bd7...

[JohnTitor]

Failed on i686-android:

  cargo:warning=/checkout/target/i686-linux-android/debug/build/libc-test-72b8e71d699a7371/out/main.c:10631:70: error: use of undeclared identifier 'MADV_DONTNEED_LOCKED'
  cargo:warning=            static const int __test_const_MADV_DONTNEED_LOCKED_val = MADV_DONTNEED_LOCKED;
  cargo:warning=                                                                     ^
  cargo:warning=1 error generated.

Seems this one isn't ignored on test_android.

[bors]

💔 Test failed - checks-actions

[tatref]

Hopefully the last fix... I should really setup some CI server to run the checks myself!

[JohnTitor]

Let's see if CI is happy, @bors r+

[bors]

📌 Commit 4858568 has been approved by JohnTitor

It is now in the queue for this repository.

[bors]

⌛ Testing commit 4858568 with merge 6a6e535...

[bors]

💔 Test failed - checks-actions

[JohnTitor]

@bors r+

[bors]

📌 Commit f3e1417 has been approved by JohnTitor

It is now in the queue for this repository.

[bors]

⌛ Testing commit f3e1417 with merge 2de3ab9...

[bors]

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 2de3ab9 to master...