Add user_regs_struct for riscv32/64 #3166
Conversation
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
|
@bors r+ |
Add user_regs_struct for riscv32/64 Copied from C header: https://elixir.bootlin.com/linux/latest/source/arch/riscv/include/uapi/asm/ptrace.h
|
💔 Test failed - checks-actions |
I forgot to make that struct pub. It should be fixed now. |
|
👍 @bors r+ |
Add user_regs_struct for riscv32/64 Copied from C header: https://elixir.bootlin.com/linux/latest/source/arch/riscv/include/uapi/asm/ptrace.h
|
💔 Test failed - checks-actions |
|
Could you squash commits into one? |
|
Oops. I have made a stupid mistake when copying the struct from C header. I should test it before opening this PR. I am very sorry for wasting your time on this PR. It should be fixed now and I have checked that it builds fine for target |
kxxt
force-pushed
the
riscv64gc-userregs
branch
from
9899d14
to
7c5c2c5
Compare
Yes. It has been squashed now. |
|
Maybe it is better to mention in the contribution guide that the contributor should successfully build and test for the target that they are working on before opening PRs. Directly following the contribution guide to run Adding this to the contribution guide would help contributors catch this kind of mistakes and save you time. |
|
I'm open to see a PR :) |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Copied from C header: https://elixir.bootlin.com/linux/latest/source/arch/riscv/include/uapi/asm/ptrace.h