Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define FICLONE on mips and power. #3212

Merged
merged 1 commit into from Apr 22, 2023

Conversation

sunfishcode
Copy link
Member

PR #3173 added definitions of FICLONE for mips and power to a generic file, however mips and power have their own versions of this file, so move their FICLONE definitions into their own files.

PR rust-lang#3173 added definitions of `FICLONE` for mips and power to
a generic file, however mips and power have their own versions of this
file, so move their `FICLONE` definitions into their own files.
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

Good call, thanks! @bors r+

@bors
Copy link
Contributor

bors commented Apr 22, 2023

📌 Commit 032a055 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 22, 2023

⌛ Testing commit 032a055 with merge c2f0f71...

@bors
Copy link
Contributor

bors commented Apr 22, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing c2f0f71 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 22, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing c2f0f71 to master...

@bors bors merged commit c2f0f71 into rust-lang:master Apr 22, 2023
11 checks passed
@bors
Copy link
Contributor

bors commented Apr 22, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@sunfishcode sunfishcode deleted the sunfishcode/ficlone-mips-power branch April 22, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants