Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haiku: fix incorrect linked library. #3222

Merged
merged 1 commit into from Apr 26, 2023

Conversation

jessicah
Copy link
Contributor

Introduced in fb2a763; using a non-existent "libunix". This is in libgnu.

Introduced in fb2a763; using a non-existent "libunix". This is in
libgnu.
@rustbot
Copy link
Collaborator

rustbot commented Apr 25, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

I'm not familiar with Haiku so just to confirm, should every Haiku users have the libgnu, i.e. does it need an additional setup? If it should it's fine.

@jessicah
Copy link
Contributor Author

Haiku has non-posix extensions in libbsd and libgnu; they're part of the system, however.

@nielx
Copy link
Contributor

nielx commented Apr 26, 2023

Can confirm that this fixes the build, the incorrect linking was introduced in #3165.

@JohnTitor
Copy link
Member

It should be fine then, thanks for clarifying! @bors r+

@bors
Copy link
Contributor

bors commented Apr 26, 2023

📌 Commit 2bc73cc has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 26, 2023

⌛ Testing commit 2bc73cc with merge f5541af...

@bors
Copy link
Contributor

bors commented Apr 26, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing f5541af to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Apr 26, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing f5541af to master...

@bors
Copy link
Contributor

bors commented Apr 26, 2023

👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request.

@bors bors merged commit f5541af into rust-lang:master Apr 26, 2023
10 of 11 checks passed
@jessicah jessicah deleted the fix-haiku-memmem branch April 28, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants