Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update crate version to 0.2.144 #3239

Merged
merged 1 commit into from May 8, 2023
Merged

Update crate version to 0.2.144 #3239

merged 1 commit into from May 8, 2023

Conversation

GuillaumeGomez
Copy link
Member

Please make a new release so I can use the new constants I added for macOS. :)

r? @Amanieu

@Amanieu
Copy link
Member

Amanieu commented May 7, 2023

r? @JohnTitor

@rustbot rustbot assigned JohnTitor and unassigned Amanieu May 7, 2023
JohnTitor
JohnTitor requested changes May 7, 2023
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the libc-test crate following the contributing guide?

@GuillaumeGomez
Copy link
Member Author

Sorry, I keep forgetting about that. Updated.

heiher
heiher reviewed May 8, 2023
View reviewed changes
Copy link
Contributor

@heiher heiher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember changing the version number in three places in the last release. 😃

@JohnTitor
Copy link
Member

Yeah, sorry that I wasn't clear, but could you also update the libc dependency version of the libc-test crate?

@GuillaumeGomez
Copy link
Member Author

Sorry, I should just have grepped on the current version number to see where I needed to update it... Updated! Thanks to both of you!

@JohnTitor
Copy link
Member

Thank you too! @bors r+

@bors
Copy link
Contributor

bors commented May 8, 2023

📌 Commit 89638b1 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented May 8, 2023

⌛ Testing commit 89638b1 with merge e06d905...

@bors
Copy link
Contributor

bors commented May 8, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing e06d905 to master...

@bors bors merged commit e06d905 into rust-lang:master May 8, 2023
11 checks passed
@GuillaumeGomez GuillaumeGomez deleted the update branch May 8, 2023 12:11
@JohnTitor
Copy link
Member

Published on crates.io: https://crates.io/crates/libc/0.2.144

@GuillaumeGomez
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heiher heiher heiher left review comments

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees

@JohnTitor JohnTitor

Labels
S-waiting-on-bors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@GuillaumeGomez @Amanieu @JohnTitor @bors @heiher @rustbot