New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MAP_UNINITIALIZED flag (Linux-only) for mmap #3274
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
@bors r+ |
add MAP_UNINITIALIZED flag (Linux-only) for mmap MAP_UNINITIALIZED is a Linux-only flag for mmap that is generically defined in mmap-common.h: https://elixir.bootlin.com/linux/latest/source/include/uapi/asm-generic/mman-common.h#L33
💔 Test failed - checks-actions |
Seems the musl header here is old and doesn't know these items, we have to ignore them on the test. See this for example: #3278 (comment) |
Ping from triage: @raymontag Could you check the above comment if you have time? Thanks! |
Closing as inactive, feel free to re-submit if you're still interested in this change. Thank you for the PR anyway! |
From the source code of glibc:
which seems to mean that this constant is defined in the kernel, not libcs. And there is a patch which also seems to prove it. If so, why we are defining this constants across |
MAP_UNINITIALIZED is a Linux-only flag for mmap that is generically defined in mmap-common.h: https://elixir.bootlin.com/linux/latest/source/include/uapi/asm-generic/mman-common.h#L33