New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define additional socket ioctls #3275
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
@bors r+ |
Define additional socket ioctls Define several socket-related `ioctl`s which aren't currently captured. Updated to include `ioctl`s from BSD systems. `libc-test` suite has not been run due to #3160.
💔 Test failed - checks-actions |
Seems the musl header here is old and doesn't know these items, we have to ignore them on the test. See this for example: #3278 (comment) |
☔ The latest upstream changes (presumably #3278) made this pull request unmergeable. Please resolve the merge conflicts. |
Friendly-ping @leftmostcat, could you check the above comment? Thanks! |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
Triage: Closing as inactive, feel free to re-submit a new PR if you're still interested in this change. Thank you anyway! |
Define several socket-related
ioctl
s which aren't currently captured. Updated to includeioctl
s from BSD systems.libc-test
suite has not been run due to #3160.