Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix size/align of ucontext_t on aarch64-apple-darwin #3312

Merged
merged 1 commit into from Aug 17, 2023

Commits on Aug 2, 2023

  1. Fix size/align of ucontext_t on aarch64-apple-darwin

    This commit effectively reverts rust-lang#2817. Currently `ucontext_t` has both
    the wrong size and the wrong alignment for aarch64-apple-darwin which
    causes problems for users referencing the structure [1]. The issue
    linked from rust-lang#2817 claimed that it fixed rust-lang#2812 but that's still an issue
    where FFI warnings are still emitted for usage of `ucontext_t` due to
    its transitive usage of `u128`. I'm not sure how to fix rust-lang#2812 myself,
    but given that rust-lang#2817 doesn't appear to solve its original intent and
    additionally the size/align are currently wrong this commit reverts in
    the meantime.
    
    [1]: bytecodealliance/wasmtime#6785 (comment)
    alexcrichton committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    283ef4b View commit details
    Browse the repository at this point in the history