Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new constants to be used in (linux) sysctl #3423

Merged
merged 3 commits into from Nov 6, 2023

Conversation

GuillaumeGomez
Copy link
Member

I started using sysctl and realized that most constants for it are actually not defined in linux so I added them.

@rustbot
Copy link
Collaborator

rustbot commented Nov 3, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@GuillaumeGomez GuillaumeGomez changed the title Add new constants to be used in sysctl Add new constants to be used in (linux) sysctl Nov 3, 2023
@JohnTitor
Copy link
Member

CI fails, could you see if the header is imported and if so, skip tests on libc-test?

@GuillaumeGomez
Copy link
Member Author

Interestingly enough, there are minor differences between linux and android in these constants (KERN_CAP_BSET only exist in android, NET_IRDA, KERN_NMI_WATCHDOG and KERN_PANIC_ON_NMI only exist in linux) so I also added them in android.

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 5, 2023

📌 Commit c370b10 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 5, 2023

⌛ Testing commit c370b10 with merge 88b3b99...

bors added a commit that referenced this pull request Nov 5, 2023
Add new constants to be used in (linux) sysctl

I started using `sysctl` and realized that most constants for it are actually not defined in linux so I added them.
@bors
Copy link
Contributor

bors commented Nov 5, 2023

💔 Test failed - checks-actions

@GuillaumeGomez
Copy link
Member Author

Seems like androidabi didn't find the KERN_CAP_BSET constant. Well, maybe it's too recent so I removed it. We can put it back later on.

@JohnTitor
Copy link
Member

👍 @bors r+

@bors
Copy link
Contributor

bors commented Nov 6, 2023

📌 Commit 7daf1dc has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 6, 2023

⌛ Testing commit 7daf1dc with merge 02c385e...

@bors
Copy link
Contributor

bors commented Nov 6, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 02c385e to main...

@bors bors merged commit 02c385e into rust-lang:main Nov 6, 2023
11 checks passed
@GuillaumeGomez
Copy link
Member Author

Thanks!

@GuillaumeGomez GuillaumeGomez deleted the sysctl-constants branch November 6, 2023 19:15
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Nov 7, 2023
88: Automated pull from `rust-lang/libc` r=Dajamante a=github-actions[bot]

This PR pulls the following changes from the [`rust-lang/libc`](https://github.com/rust-lang/libc) repository:

* rust-lang/libc#3423
* rust-lang/libc#3390


Co-authored-by: David Carlier <devnexen@gmail.com>
Co-authored-by: Guillaume Gomez <guillaume1.gomez@gmail.com>
Co-authored-by: bors <bors@rust-lang.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants