Add the NI_IDN getnameinfo() extension #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
JohnTitor
approved these changes
Nov 12, 2023
|
Thank you! @bors r+ |
bors
added a commit
that referenced
this pull request
Nov 12, 2023
…itor Add the NI_IDN getnameinfo() extension This PR adds the `NI_IDN` getnameinfo extension. I've also tried to add the other two extensions (see: https://man7.org/linux/man-pages/man3/getnameinfo.3.html), but the tests would fail (`-Werror`) because those two are deprecated.
|
💔 Test failed - checks-actions |
|
CI fails because musl targets use Linux v4 kernel, could you skip the test for musl? A brief instruction is here: https://github.com/rust-lang/libc/blob/main/CONTRIBUTING.md#test-before-you-commit |
|
Let's see if I got it right. |
|
Yeah, it should work. Could you squash commits into one? |
adder32
force-pushed
the
define-getname-info-extensions
branch
from
afed7dd
to
900ef0d
Compare
adder32
force-pushed
the
define-getname-info-extensions
branch
from
900ef0d
to
d351b3b
Compare
|
Sure! |
|
Thank you! @bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
NI_IDNgetnameinfo extension.I've also tried to add the other two extensions (see: https://man7.org/linux/man-pages/man3/getnameinfo.3.html), but the tests would fail (
-Werror) because those two are deprecated.